Add platform-specific notes #672
Conversation
vweevers
added
documentation
|
Fine by me, but what's the reason exactly? Are the prebuilds built on Ubuntu 16.04 or something later than Jessie? Where are the prebuilds made and what hosts are available? |
|
The linux prebuilds are built on Travis, that's Ubuntu 16.04 with gcc 5.4.0. |
|
OK, looks like GitHub Actions is limited to Ubuntu too. Pretty convenient for testing, not so great for producing maximally compatible binaries. I think you're going to need to expand your list to include RHEL 7 & CentOS 7. Expand the table @ https://en.wikipedia.org/wiki/GNU_C_Library#Version_history, find Ubuntu 16.04, and everything before that version of glibc is ruled out by building binaries on 16.04. As long as There is a way around this though, Travis supports Docker apparently, I've never used this, but it ought to be possible to pull down a CentOS 7 image, put the latest devtoolset on it, then you get the latest GCC that will compile against an old libc. Not uncomplicated but if |
We already do this for Android & Alpine, might be easy! I'll open an issue. |
|
ahhhh https://github.com/prebuild/docker-images, I see. Maybe I'll PR an initial proposal there. |
* Remove prebuild settings from standard "linux" job * Add centos7 job with prebuild settings * Add centos7-devtoolset7 docker image prebuild script Ref: prebuild/docker-images#8 Ref: #672
README.md
Outdated
| ### Notes | ||
|
|
||
| - If you get compilation errors on Node.js 12, please ensure you have `leveldown` >= 5. This can be checked by running `npm ls leveldown`. | ||
| - On Debian 8 you must either update glibc through external sources like Ubuntu (to be able to load prebuilt binaries) or use `--build-from-source`. |
There was a problem hiding this comment.
So this part might be solved by using the docker image provided by @rvagg ?
There was a problem hiding this comment.
yes, and I'd love to help confirm if you can produce a test binary using the centos7-devtoolset7 image
vweevers
changed the title
* Remove prebuild settings from standard "linux" job * Add centos7 job with prebuild settings * Add centos7-devtoolset7 docker image prebuild script Ref: prebuild/docker-images#8 Ref: #672
Ref nodejs/citgm#751.
Is everyone OK with our prebuilds not being compatible with Debian 8? Or should we fix that?
/cc @rvagg